Blasting bugs and passing reviews — Kalendar devlog 19

https://25years.kde.org/assets/img/banner_blue_2500.webp

First of all: happy birthday to KDE! If you hadn’t heard, KDE is now 25 years old (which means that KDE is 3 years older than I am — oof). I first started using KDE (3) on Mandrake after, out of the blue, my dad decided to nuke our family computer’s Windows 95 installation. I was 3 at the time, and very angry at the fact that I would no longer be able to play Monster Truck Madness. Now, here we are, almost 20 years later!

Without the efforts of the KDE community and its amazing software, Kalendar wouldn’t exist. We depend on so many different things — Kirigami, Akonadi, the KFrameworks, and more — that without two and a half decades of prior efforts from other community members, this application just wouldn’t exist. So, from myself and from everyone who has been involved in creating Kalendar — thanks!!

Back to Kalendar. Last Sunday, we submitted Kalendar for KDE Review… and we received our first review! That has meant fixing bugs, improving UI stuff, and more. Seriously — scroll to the bugfix section and check it out. As always, though, we have some new features to show off too.

Note: Kalendar is still under heavy development. You’re free to poke around and try it out, but it is not yet final software! If you want to contribute to its development, join us in Kalendar’s Matrix room.

Our progress on KDE review

Last Sunday, we received our first round of feedback for KDE Review (thanks Albert!) and have spent this week addressing the issues brought up there. These were mainly technical, but we also had some useful UI feedback which we have taken on board and addressed (and are included in this update post).

You can follow the KDE Review process for Kalendar on the mailing list, or keep tuning in to the weekly updates, where we will let you know how things are going.

Tweaks to Kalendar’s logo

Every week we tweak and adjust the UI to make sure it is as good as it can be. The same goes for our logo 😉

Icon Kalendar

After revealing our new logo last week, we had some feedback that the large number of small squares would be difficult to distinguish as a small icon. We therefore have tweaked the logo to have just four, larger squares rather than the 6 it previously had, which should make them much easier to distinguish at the small size of an icon.

We are now on apps.kde.org and plasma-mobile.org!

Kalendar now shows up on both apps.kde.org and plasma-mobile.org. You can find find information about our app, our repository, and more in these sites.

Improved support for mirrored layouts

!117: Layout mirroring support for menubar (Carl Schwan)

image

Kalendar should now adapt better to languages and locales where the layouts are right-to-left thanks to some changes in how the the relevant components assign actions to action slots. This should make Kalendar’s layout more logical when using it in right-to-left mode!

Resizeable incidence information drawer!

!86: Make it possible to resize the right drawer (Carl Schwan)

Since we first introduced the incidence information drawer, we thought it would be nice to make it resizeable on the desktop and to let the user decide how much space it should take up. Well, we now have this feature, and it works pretty dang well!

The set size of the incidence information drawer is remembered so it will remain consistent once it is set by you, no matter which incidence you open or how many times you have closed Kalendar.

Improved date picker

!119: Rewrite date picker and unify infinite calendar view models (Claudio Cambra)

We have completely rewritten the date picker. Why? Well, to improve it!

Our previous iteration was buggy and difficult to use on mobile, owing to the fact that you had to interact with tiny buttons up in the picker’s header. Now, the datepicker is bug-free, and you can interact with it as you would expect to interact with any of Kalendar’s other calendar views.

The month, year, and decade views are all infinitely swipeable, letting you select any date you would like by simply swiping to it and tapping it. You can also easily return to the current day by tapping the ‘Today’ button. We have made sure to retain the same design as Plasma’s Calendar widget, which should make this picker feel very familiar.

We have also submitted a merge request to include this date picker in the Kirigami Addons package, which hopefully means that it will be easily usable by other KDE app developers in the near future!

Easy deselection of incidences by clicking on empty space

!121: Deselect incidence upon clicking on empty space (Claudio Cambra)

You can now easily deselect an incidence (and, by extension, close the incidence information drawer) on the desktop by clicking on empty space within your current calendar view. This makes Kalendar behave more as you would expect it to, and help you easily dismiss the drawer when you don’t want it to be there.

Bug-fixes and other changes

Pretty sure this is one of our longest bug-fix sections yet…

Commit 5864c59e: Fixed incidence editor not letting you save edited task when clicking edit in incidence info from tasks view (Claudio Cambra)

  • The gigantic commit message explains exactly what was fixed: if you went to click ‘edit’ in the incidence information drawer after selecting a task in the tasks view, it wouldn’t let you save the changes to the task. Now fixed.

Commit 4fe0bd89: Full reuse compliance (Carl Schwan)

  • Kalendar now has full REUSE compliance and we added a bunch of legal-related files and headers.

Commit 5bf9ce59: Fix sort read (Claudio Cambra)
Commit 1ccf7700: Fix sorting in tasks view and ensure that when sorting by values, null values are always at bottom (Claudio Cambra)
Commit c6bdd120: More sort fixes (Claudio Cambra)

  • Fixed numerous issues with sorting in the tasks view. Sorting should now behave as expected: null values are always at the bottom, with non-null values being sorted in the expected order above them.
  • Sort options are now correctly saved and restored after closing the application.

Commit cfa95dd9: Add KLocalizedString::setApplicationDomain(kalendar) (Claudio Cambra)

  • Kalendar now properly sets KLocalizedString domain, needed to have any translations at all (!!)

Commit bf476940: Fixed kf.i18n: ‘0 instead of 1 arguments to message…’ error (Claudio Cambra)

  • Opening an incidence no longer outputs a console error about i18n arguments

Commit 6f3b5348: TitleDateButton now uses i18n based standaloneMonthName month-year strings (Claudio Cambra)
Commit 37536b54: Date picker no uses standaloneMonthName (Claudio Cambra)

  • Various parts of Kalendar now use i18n based standaloneMonthName month-year strings to avoid risk of ‘of Month’ strings in certain languages (e.g. of November 2019 in the page title)

Commit edcc6bb6: Moved regex out of AttendeeStatusModel constructor loop (Claudio Cambra)

  • Improved efficiency of AttendeeStatusModel constructor, which should improve performance a little (though admittedly not a huge amount)

Commit aaadf2af: Fixed property warnings (Claudio Cambra)

  • Compiling Kalendar should no longer result in several warnings regarding Q_PROPERTY properties of a number of classes

Commit 9602d477: Remove not needed kpackage dependency (Carl Schwan)

  • Removed an unneeded dependency, reducing the number of required packages to install for Kalendar

Commit a0672920: Fix deletion of attachments from incidence editor (Claudio Cambra)

  • Deleting attachments now works again

Commit 1a198c46: Todo page now loads correctly when opening Kalendar (Claudio Cambra)

  • The todo page now loads correctly when opening Kalendar, instead of getting stuck in a half-loaded state and without correct sorting.
  • Additionally, adding a new task should make it appear in the correct place according to the current sorting.

Commit 97f6f42c: Fixed some error messages (Claudio Cambra)
Commit c4433124: Fixed some more error messages (Claudio Cambra)

  • Fixed a bunch of QML errors regarding undefined/null variables

Commit ac6fbac2: Links in incidence info now have pointy hand cursor (Claudio Cambra)

  • Hovering above a link — whether it is a location website, an attendee’s email, or something else — should now change your cursor into a pointing hand cursor, as you would expect

Commit 9ebc2bc6: Make IncidenceEditor’s description text area wrap it’s text (Felipe Kinoshita)

  • The incidence editor’s description text area no longer expands in width before wrapping its contained text

!120: Add vendored TreeView components (Claudio Cambra)

  • This is an important change: you no longer need to have Kirigami Addons installed in order to run Kalendar. This has been necessary for passing KDE Review as Kirigami Addons is still technically an unstable project, and something we cannot depend on until it is considered stable. This should make it a lot easier for you to test and run Kalendar on your own system.

Commit 2547d957: Remove minor build warning (Carl Schwan)

  • This eliminates yet another compilation warning.

Commit 1df8a16a: Fix not being able to interact with task tree view (Carl Schwan)

  • This eliminates a regression caused by MR 121 which prevented you from clicking on certain parts of the task view’s tree list.

Commit edfcf7a5: Fix QML warning in task view (Carl Schwan)

  • Fix warnings caused by grid layout used by incidence delegates in the tasks tree view

Commit 149b594c: Fixed leak in AttendeeStatusModel constructor (Claudio Cambra)

  • Fixed Valgrind issue caused by AttendeeStatusModel constructor

Coming up next

Is there anything you’d like to see added to Kalendar? Get in touch! I’m @clau-cambra:kde.org on Matrix.

6 Replies to “Blasting bugs and passing reviews — Kalendar devlog 19”

  1. It’s always great to read about your improvements. I’m almost inclined to check out the code myself.

    As I watched your short videos: A constantly rearranging UI (incident sidebar hidden/shown and the calendar resizing accordingly) is rather uncomfortable on a desktop. I’d rather keep the latest incident information visible and a certain number N of previously opened ones as “one-liners” (date + title) as LRU list accessible below.

    1. You’re very welcome to start contributing!

      On the resizing: a thing to mention are that the sidebar is only dismissed if you purposefully do so (i.e. click on empty space or close it manually). So if you’d like to keep it open, it will remain open. Your proposal is interesting and I will look into it 🙂

  2. Awesome! About the date picker: I think it’d be useful if the date names (Monday, Tuesday …) would be shown there too and maybe even the week number.
    Also on first open there’s a weird animation before it shows the months. Is that a bug? 🙂

    1. Hey Alex,

      1. Yes, this is fixed now. Week numbers are omitted due to size constraints, but can be included in larger formats — will look into this
      2. Yeah, need to look into that. Thanks for pointing it out

  3. Also I’d find it very useful to have the date picker to be always visible on the left side, just as Thunderbird’s Lightining or MS Outlook does it.

    It gives a good overview and quicker access and in my case is more interesting than having the displayed calendars on the left side: I guess one does not enable/disable them all the time while switching dates is a more frequently used task.

Leave a Reply

Your email address will not be published. Required fields are marked *